- mis-spell in comments. I should use the a spell check add-in
- copy and paste others code without change the styles
- use the const function whenever possible
- use std::string::empty() instead of compare with empty string
- include all dependent header in the header definition vs. depending on the cpp file include sequence.
- pay more attention to resource release, return true/false path even if most did not matter.
Thursday, April 15, 2010
code review lesson learned
Just had some code review and got a lot of comments:
Subscribe to:
Post Comments (Atom)
No comments:
Post a Comment